-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gravity removal ;) unused var that was 1 on ALL tiles #6728
Conversation
I am not sure if this was fixed but in certain rare cases of the crashing of the dropship into the Almayer, you actually expose the back port to space. And so when you go out there, you start floating. It's just niche, and I don't think you should fully remove the floating animations. But that's just my only conclusion until that gets fixed/is fixed. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
I'd like gravity to remain should I ever finish "Space Hulk" (map where you board another ship.) |
for those who did not read it SPACE has ALSO gravity 1 same as ALL the other tiles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
downvotes and comments seem to be under the impression this removes floating when you hit a space tile, which it does not
About the pull request
newton created gravity and I removed it. (it is just dead apendige left from old ss13)
Explain why it's good for the game
less mess in the code, removes (at least some of it still looking what all can be removed with it) gravity code
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑
del: Removes gravity :)
/:cl: